Skip to content

Conversation

@alextech
Copy link
Contributor

@alextech alextech commented Jul 9, 2025

Adds support for Gherkin doc string https://cucumber.io/docs/gherkin/reference/#doc-strings

AST from gherkin parser already has the node for it, so just add it to the Step class.

@alextech alextech requested a review from a team as a code owner July 9, 2025 20:31
@alextech
Copy link
Contributor Author

alextech commented Jul 9, 2025

Wondering if Step::docString should be std::optional to designate whether there is no doc string at all or it is there but intentionally left empty. Have not done that so far, because not having it and it being empty ends up with the same result and Step::table already follows the logic of empty vector, therefore does not exist.

@magi-arun magi-arun requested a review from daantimmer July 11, 2025 07:12
@daantimmer
Copy link
Collaborator

Hello @alextech thanks for your contribution! Would you please have a look at the failing build & test runs? Some tests require updating.

- missed doctype parameter in tests
@alextech alextech changed the title Add gherkin doc string support feat: Add gherkin doc string support Aug 11, 2025
@alextech alextech changed the title feat: Add gherkin doc string support feat: add gherkin doc string support Aug 11, 2025
@alextech
Copy link
Contributor Author

Hello @daantimmer thanks, for letting the test runner through. One of the jobs needs SONAR_TOKEN updated

@daantimmer
Copy link
Collaborator

Hello @daantimmer thanks, for letting the test runner through. One of the jobs needs SONAR_TOKEN updated

Sadly, it doesn't. All tokens are always private and I can't 'share' or 'use' them for external contributors. Which is annoying.

@daantimmer
Copy link
Collaborator

Fixed in #214

@daantimmer daantimmer closed this Sep 16, 2025
@alextech alextech deleted the doc_string branch October 1, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants